Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: podresources: GA in 1.28 #3980

Merged
merged 1 commit into from
May 25, 2023
Merged

node: podresources: GA in 1.28 #3980

merged 1 commit into from
May 25, 2023

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented May 3, 2023

@ffromani
node: podresources: GA in 1.28
b9ae15d 
The 1.27 GA graduation was very close, but was missed.
Update the GA to 1.28.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2023
@ffromani ffromani mentioned this pull request May 3, 2023
Closed
4 tasks
@ffromani
Copy link
Contributor Author

ffromani commented May 3, 2023

/cc @mrunalp @SergeyKanzhelev

Per May 2 sig-node initial 1.28 planning. Trivial changes.

@ffromani ffromani mentioned this pull request May 3, 2023
Merged
@bart0sh
Copy link
Contributor

bart0sh commented May 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ffromani
Copy link
Contributor Author

ffromani commented May 4, 2023

once this merges, I'll unhold kubernetes/kubernetes#116525 and ... we're pretty much done! :)

@bart0sh
Copy link
Contributor

bart0sh commented May 5, 2023

/assign @mrunalp @derekwaynecarr @dchen1107

swatisehgal
swatisehgal approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ffromani
Copy link
Contributor Author

/assign @dchen1107

for final approval (require lead approval)

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, ffromani, mrunalp, pacoxu, SergeyKanzhelev, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7cb9920 into kubernetes:master May 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 25, 2023
@ffromani ffromani mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@pacoxu pacoxu pacoxu approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@swatisehgal swatisehgal swatisehgal approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
9 participants
@ffromani @bart0sh @dchen1107 @k8s-ci-robot @mrunalp @pacoxu @SergeyKanzhelev @swatisehgal @derekwaynecarr